Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneMath][RNG] Updated supported types for Discrete Uniform #612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[oneMath][RNG] Updated supported types for Discrete Uniform #612

wants to merge 1 commit into from

Conversation

egrabovskaya
Copy link
Contributor

@egrabovskaya egrabovskaya commented Feb 21, 2025 •
edited
Loading

Since (u)int8 and (u)int16 types support was added to Uniform at the DPNP request

@egrabovskaya
Copy link
Contributor Author

@andreyfe1, @iMartyan, could you please take a look?

andreyfe1
andreyfe1 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

iMartyan
iMartyan approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@iMartyan iMartyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyfe1 andreyfe1 andreyfe1 approved these changes

@iMartyan iMartyan iMartyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egrabovskaya @andreyfe1 @iMartyan