Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove vestigial Python code and define dependency for oneDAL make builds #2929

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
1 change: 1 addition & 0 deletions .ci/pipeline/ci.yml
Original file line number Diff line number Diff line change
@@ -45,6 +45,7 @@ jobs:
vmImage: '$(VM_IMAGE)'
steps:
- script: |
echo $(Build.SourceBranch)
.ci/env/apt.sh clang-format
.ci/env/editorconfig-checker.sh
displayName: 'Install Dependencies'
2 changes: 1 addition & 1 deletion INSTALL.md
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ Required Software:
* C/C++ Compiler
* [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) and [oneMKL](https://www.intel.com/content/www/us/en/developer/tools/oneapi/onemkl.html) if building with SYCL support
* BLAS and LAPACK libraries - both provided by oneMKL
* Python version 3.9 or higher
* Python version 2.7 or higher
* TBB library (repository contains script to download it)
* Microsoft Visual Studio\* (Windows\* only)
* [MSYS2](http://msys2.github.io) (Windows\* only)
6 changes: 3 additions & 3 deletions deploy/pkg-config/generate_pkgconfig.py
Original file line number Diff line number Diff line change
@@ -33,8 +33,8 @@ def detect_cpu_architecture():
elif architecture.startswith('arm') or architecture == 'aarch64':
return 'aarch64'
else:
sys.stderr.write(f"Unknown Architecture {architecture} Detected. " \
"Only 'x86_64', 'AMD64' and 'aarch64' supported.\n")
sys.stderr.write("Unknown Architecture {} Detected. "
"Only 'x86_64', 'AMD64' and 'aarch64' supported.\n".format(architecture))
sys.exit(1)

LIBS_PAR_STAT, LIBS_PAR_DYN = [], []
@@ -72,7 +72,7 @@ def detect_cpu_architecture():
elif ARCH == 'aarch64':
LIBDIR = 'lib/arm'
else:
sys.stderr.write(f"Unknown CPU architecture '{ARCH}'\n")
sys.stderr.write("Unknown CPU architecture '{}'\n".format(ARCH))

SUFF_DYN_LIB = ".so"
SUFF_STAT_LIB = ".a"