init commit for svm fix#3659
Draft
Alexandr-Solovev wants to merge 2 commits into
Draft
Conversation
| // arrays of a oneapi svm model. SVs and coeffs are stored grouped by class in | ||
| // increasing class order; n_support_per_class gives the per-class block sizes. | ||
| // Layout assumptions follow the daal one-vs-one trainer: | ||
| // support_vectors : [sum(n_support_per_class), n_features] |
Contributor
There was a problem hiding this comment.
This doesn't match with what is produced as output:
https://uxlfoundation.github.io/oneDAL/api/algorithms/svm/svm.html#_CPPv4N6oneapi3dal3svm12train_result15support_vectorsE
| return 1; | ||
| } | ||
|
|
||
| std::cout << "PASS" << std::endl; |
Contributor
There was a problem hiding this comment.
Please make this a unit test instead of example.
| .set_first_class_response(old_unique_responses.first) | ||
| .set_second_class_response(old_unique_responses.second); | ||
| .set_second_class_response(old_unique_responses.second) | ||
| .set_class_count(2); |
Contributor
There was a problem hiding this comment.
Please make it error out when a user tries to re-assign multi-class arrays to a GPU estimator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Completeness and readability
Testing
Performance