build: adding compression in dpc part of the code#3664
Draft
Alexandr-Solovev wants to merge 1 commit into
Draft
Conversation
| -shared-libsan, otherwise they will crash at startup with | ||
| "ASan runtime does not come first in initial library list". | ||
| Workaround for stubborn link orders: | ||
| LD_PRELOAD=$(icpx -print-file-name=libclang_rt.asan-x86_64.so) ./bin |
Contributor
There was a problem hiding this comment.
@Alexandr-Solovev Did you manage to run DPC examples like this?
| -DEBC.icx = $(if $(OS_is_win),-debug:all -Z7,-g) -fno-system-debug -Wno-pass-failed | ||
| # ABI-safe debug-size reductions on Linux: zstd-compress .debug_* sections and dedup | ||
| # DWARF type DIEs across TUs. Both are transparent to gdb/lldb and don't change emitted code. | ||
| -DEBC.icx = $(if $(OS_is_win),-debug:all -Z7,-g -gz=zstd -fdebug-types-section) -fno-system-debug -Wno-pass-failed |
Contributor
There was a problem hiding this comment.
Why -Wno-pass-failed? That shouldn't have any impact in the generated file when the compilation succeeds.
| # ABI-safe debug-size reductions for the host side of DPC++: zstd-compress .debug_* | ||
| # sections and dedup DWARF type DIEs. Device-side debug info is controlled separately | ||
| # via --offload-compress / --offload-compression-level on the link line. | ||
| -DEBC.dpcpp = $(if $(OS_is_win),-debug:all -Z7,-g -gz=zstd -fdebug-types-section) -fno-system-debug |
Contributor
There was a problem hiding this comment.
Does this come up with extra requirements to compile like 7zip or libzstd? Or are those bundled in the compiler?
Contributor
|
@Alexandr-Solovev Is it expectable that this would make the linker step slower? How long does it take to build a sanitized DPC build under this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Completeness and readability
Testing
Performance