Add transpose operation for F-order data and fix validation for GPU#3665
Draft
avolkov-intel wants to merge 3 commits into
Draft
Add transpose operation for F-order data and fix validation for GPU#3665avolkov-intel wants to merge 3 commits into
avolkov-intel wants to merge 3 commits into
Conversation
Contributor
|
@avolkov-intel What about logistic regression? |
Contributor
|
@avolkov-intel @Vika-F Looks like the 'copy' function is not using omatcopy when doing transposes: Perhaps that could be improved in a different PR. Omatcopy should do it in parallel and can have good speedups on CPU when transposing matrices. For the non-transpose case with strides, it could also use 'lacpy' from MKL instead: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Completeness and readability
Testing
Performance