-
Notifications
You must be signed in to change notification settings - Fork 1k
common: postops: add post-ops support for binary select op #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
20dff17
to
7edca7d
Compare
7edca7d
to
43a333b
Compare
5dc4c66
to
9a186cc
Compare
4430430
to
6b34aa8
Compare
6b34aa8
to
4dad525
Compare
4dad525
to
b87f40b
Compare
make test |
2eb1881
to
cec796c
Compare
make test |
cec796c
to
0b2eb56
Compare
make test |
0592feb
to
1495176
Compare
make test |
81af0ca
to
1503ebc
Compare
make test |
tests/benchdnn/doc/knobs_attr.md
Outdated
The arguments for each tensor are provided in the form `DT.MASK_INPUT.TAG`, | ||
with the arguments for the third tensor positioned after that of the second | ||
and are separated by `:`. The arguments are optional for the third tensor and | ||
the data type value for the third tensor is fixed at `s8`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranukund, could you, please, check out this page?
1503ebc
to
b2dd6e7
Compare
make test |
b2dd6e7
to
e0d8380
Compare
make test |
Description
The PR adds updates post-ops implementations so that they support binary select operation as a post-op:
The updates account for the third conditional input that the select op requires for computation.
Implements MFDNN-12883.
This also introduces a new benchdnn format for providing arguments to multiple
src
tensors for a single post-op:Testcase:
(Currently, there is no broadcasting support for the conditional
src2
tensor. The data type, mask policy and tag for thesrc2
tensor are fixed ass8
,common
andany
respectively).