-
Notifications
You must be signed in to change notification settings - Fork 1.1k
common: postops: add post-ops support for binary select op #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20dff17
to
7edca7d
Compare
7edca7d
to
43a333b
Compare
5dc4c66
to
9a186cc
Compare
4430430
to
6b34aa8
Compare
6b34aa8
to
4dad525
Compare
4dad525
to
b87f40b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments suggested, please incorporate as you see fit, thanks!
e0d8380
to
c655684
Compare
a901389
to
61cd635
Compare
61cd635
to
0cfdd68
Compare
make test |
0cfdd68
to
72c46fe
Compare
72c46fe
to
1be63b7
Compare
make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment to address. I'm fine with the rest.
1be63b7
to
a527e26
Compare
a527e26
to
bfaa38b
Compare
make test |
Description
The PR adds updates post-ops implementations so that they support binary select operation as a post-op:
The updates account for the third conditional input that the select op requires for computation.
Implements MFDNN-12883.
This also introduces a new benchdnn format for providing arguments to multiple
src
tensors for a single post-op:Testcase:
(Currently, there is no broadcasting support for the conditional
src2
tensor. The data type, mask policy and tag for thesrc2
tensor are fixed ass8
,common
andany
respectively).