benchdnn: mem check: touch up #3153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make test |
rjoursler
approved these changes
Apr 24, 2025
dzarukin
force-pushed
the
dzarukin/benchdnn_mem_check_touch_up
branch
from
43b2989 to
9c7ee8a
Compare
Updated warning conditions To allow misconduct of small allocations that can't be checked without significant engineering effort across benchdnn. Also moved the flow to stash the expected value and set it in doit right before each call would start allocating memory. Otherwise, in parallel create mode all primitives would be validated against mem sizes provided by the last primitive in the list.
dzarukin
force-pushed
the
dzarukin/benchdnn_mem_check_touch_up
branch
from
9c7ee8a to
1b63b78
Compare
|
make test |
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the clause upon which a warning message will pop up.
PR includes a test commit just to see if error is still triggered for anything, will be removed.
Also contains a small fix to a
--mem-check=falsescenario.