src: cpu: aarch64: Enable JIT fp16 -> fp16 reorder #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-aarch64
karmeh01
force-pushed
the
jit_reorder_f16
branch
from
7181852 to
9010626
Compare
karmeh01
changed the title
|
Thanks for the PR. changes LGTM! |
|
No they are not. I will add them and update the PR |
…16 --ddt=f16 case
|
82 tests added to check the --sdt=f16 --ddt=f16 case |
aditew01
suggested changes
Apr 25, 2025
| @@ -11,7 +11,7 @@ | |||
| --dtag=gOIhw4i8o2i 4x16x16x3x3 2x16x6x3x2 2x2x10x2x3 | |||
| --dtag=gOIhw4o8i2o 4x16x16x3x3 2x16x6x3x2 2x2x10x2x3 | |||
|
|
|||
| --sdt=f16 --ddt=f32,bf16,s8,u8,f8_e5m2,f8_e4m3 | |||
| --sdt=f16 --ddt=f16,f32,bf16,s8,u8,f8_e5m2,f8_e4m3 | |||
There was a problem hiding this comment.
this is redundant, isn't it?
aditew01
reviewed
Apr 25, 2025
| @@ -1,6 +1,6 @@ | |||
| # f32, s8, u8 <--> f16 | |||
| --reset | |||
| --sdt=f32,bf16,s8,u8,f8_e5m2,f8_e4m3 --ddt=f16 | |||
| --sdt=f16,f32,bf16,s8,u8,f8_e5m2,f8_e4m3 --ddt=f16 | |||
There was a problem hiding this comment.
LGTM! this should be enough.
aditew01
approved these changes
Apr 25, 2025
aditew01
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for fp16 JIT reorder for data type f16->f16.
General
make testandmake test_benchdnn_*) pass locally for each commit?Performance improvements
Below are small test case logs that demonstrate performance numbers before and after.
./tests/benchdnn/benchdnn --reorder --sdt=f16 --ddt=f16 --stag=abc --dtag=aBc8b --mode=p 1x4096x4096(new) jit:uni:
total perf: min(ms):0.564941 avg(ms):1.01874(old) simple:any:
total perf: min(ms):25.6047 avg(ms):27.257