-
Notifications
You must be signed in to change notification settings - Fork 1.1k
src: cpu: aarch64: Enable JIT fp16 -> fp16 reorder #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7181852
to
9010626
Compare
Thanks for the PR. changes LGTM! |
No they are not. I will add them and update the PR |
82 tests added to check the --sdt=f16 --ddt=f16 case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4671f98
to
6869d31
Compare
Description
This PR adds support for fp16 JIT reorder for data type f16->f16.
General
make test
andmake test_benchdnn_*
) pass locally for each commit?Performance improvements
Below are small test case logs that demonstrate performance numbers before and after.
./tests/benchdnn/benchdnn --reorder --sdt=f16 --ddt=f16 --stag=abc --dtag=aBc8b --mode=p 1x4096x4096
(new) jit:uni:
total perf: min(ms):0.564941 avg(ms):1.01874
(old) simple:any:
total perf: min(ms):25.6047 avg(ms):27.257