xe: sdpa: fix register overflow warning in prefetch functions #3164
+47
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
petercad
approved these changes
Apr 24, 2025
atkassen
approved these changes
Apr 25, 2025
umar456
force-pushed
the
uarshad/sdpa_reg_overflow_fix
branch
from
d65268e to
110c21d
Compare
The micro_sdpa kernel was throwing an overflow warning for when the PREFETCH_REMAINDER was set to zero. This was caused because the pointer offset calculation was being done within the function call. Moving the offset calculation outside of the call fixes the register overflow warning.
umar456
force-pushed
the
uarshad/sdpa_reg_overflow_fix
branch
from
110c21d to
2c16d79
Compare
|
make test |
dzarukin
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The micro_sdpa kernel was throwing an overflow warning for when the
PREFETCH_REMAINDER was set to zero. This was caused because the pointer offset
calculation was being done within the function call. Moving the offset
calculation outside of the call fixes the register overflow warning.
Fixes: https://jira.devtools.intel.com/browse/MFDNN-13443