Skip to content

generic: sycl: Change to indexing in conv kernel #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShanoToni
Copy link
Contributor

@ShanoToni ShanoToni commented Apr 30, 2025

Description

Changes to the sycl convolution kernel resolve failing benchdnn tests:

--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --dt=u8:s8:u8 --strides=903168x1x4032x9::6422528x1x28672x128 g1mb1ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --dt=u8:s8:u8 --strides=903168x1x4032x9::6422528x1x28672x128 g1mb16ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --dt=f16:f16:f16 --strides=903168x1x4032x9::6422528x1x28672x128 g1mb1ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --dt=f16:f16:f16 --strides=903168x1x4032x9::6422528x1x28672x128 g1mb16ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --strides=903168x1x4032x9::6422528x1x28672x128 g1mb1ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
 --mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --strides=903168x1x4032x9::6422528x1x28672x128 g1mb16ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"
--mode-modifier=P --conv --engine=gpu --allow-enum-tags-only=false --check-ref-impl=true --dir=BWD_D --dt=u8:s8:u8 --strides=903168x1x4032x9::6422528x1x28672x128 g1mb1ic3ih224oc64oh112kh7sh2ph3n"resnet_50:conv1"

see MFDNN-13275

Checklist

General

  • [ x ] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [ x ] Have you formatted the code using clang-format?

@ShanoToni ShanoToni requested a review from a team as a code owner April 30, 2025 12:01
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Apr 30, 2025
@ShanoToni
Copy link
Contributor Author

make test
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

@ShanoToni
Copy link
Contributor Author

make test
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants