[WIP][GPU] Add dropout to jit path for matmul #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
Simonsays095
reviewed
Jan 9, 2026
src/gpu/intel/gemm/with_post_ops.cpp
Outdated
| const bool with_wei_scales | ||
| = !attr_scales.has_default_values(DNNL_ARG_WEIGHTS); | ||
| const bool with_dst_scales = !attr_scales.has_default_values(DNNL_ARG_DST); | ||
| const bool with_dropout = !attr()->dropout_.has_defaul_values(); |
Contributor
There was a problem hiding this comment.
Suggested change
| const bool with_dropout = !attr()->dropout_.has_defaul_values(); | |
| const bool with_dropout = !attr()->dropout_.has_default_values(); |
src/gpu/intel/gemm/with_post_ops.cpp
Outdated
Comment on lines
265
to
261
| kernel_ctx.define_int("USE_OFFSET", use_offset); | ||
| kernel_ctx.define_int("USE_HOST_SCALARS", use_host_scalars); | ||
| kernel_ctx.define_int("HAS_OUTPUT_MASK", has_output_mask); |
Contributor
There was a problem hiding this comment.
Can you name these DROPOUT_* so it's clearer in the kernel what's being controlled by these macros? Specifically, USE_HOST_SCALARS is confusing as there are other scalars that may be supplied on the host or device side.
Contributor
Author
There was a problem hiding this comment.
They all actually come withing the WITH_DROPOUT macro, so it is going to be pretty clear. But I added the DROPOUT_* to HOST_SCALARS for clarity
src/gpu/intel/gemm/with_post_ops.cpp
Outdated
Comment on lines
340
to
337
| arg_list.set(idx++, GEMM_CTX_ARG_STORAGE(dropout_seed)); | ||
| arg_list.set(idx++, GEMM_CTX_ARG_STORAGE(dropout_offset)); | ||
| arg_list.set(idx, GEMM_CTX_ARG_STORAGE(dropout_prob)); |
Contributor
There was a problem hiding this comment.
I think these need to be set in gpu/intel/matmul/gemm.cpp similarly to the other gemm:exec_args_t values.
h-sadia
force-pushed
the
hsadia/drpout_jit_path
branch
8 times, most recently
from
131cfc2 to
f4fabd4
Compare
h-sadia
force-pushed
the
hsadia/drpout_jit_path
branch
2 times, most recently
from
3b947f2 to
83991a2
Compare
h-sadia
force-pushed
the
hsadia/drpout_jit_path
branch
from
83991a2 to
bc6ff50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of enabling dropout as request from GRAPH API. This will enable SDPA on the fast path.