cpu: aarch64: Enable int8 brgconv for SVE128 #4515
Draft
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about enabling int8 brgconv for SVE128. Previously they where being routed to
gemm_s8s8s32:reforgemm_s8u8s32:ref, and now they are handled bybrgconv:sve_128orbrgconv_1x1:sve_128resulting in a significant improvement, as shown in the Performance Improvements section below.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?All the NIGHTLY tests are passing when the command below is executed:
ctest -j$(nproc) -E $(../.github/automation/aarch64/skipped-tests.sh)Performance improvements
On a Graviton4, without this PR:
On Graviton4, with this PR:
On average, performance improved by approximately 100%.