cpu: aarch64: remove redundant embd_bcast flag #4516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag appears to have been copied verbatim from x64, and it doesn't seem to apply to AArch64. Specifically, on x64, turning the flag on enables the use of fewer instructions. On AArch64, it uses _more_ instructions. The comment about when it is turned on also doesn't make sense, vector length is orthogonal to features.
github-actions
bot
added
the
platform:cpu-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag appears to have been copied verbatim from x64, and it doesn't seem to apply to AArch64. Specifically, on x64, turning the flag on enables the use of fewer instructions. On AArch64, it uses more instructions. The comment about when it is turned on also doesn't make sense, vector length is orthogonal to features.
Removing it to make it easier to add new functionality to
jit_brgemm_kernel_t.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?