xe: gemm: revert gemmstone API changes #4518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
atkassen
approved these changes
Jan 9, 2026
kealan-barbieri
approved these changes
Jan 9, 2026
Simonsays095
force-pushed
the
revert_gemmstone_api
branch
from
ac5abf9 to
df19d9b
Compare
Contributor
Author
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes alter a user-facing API in gemmstone (the kernel selector's select function) which other teams use. Since the change in API is unnecessary, this PR reverts that change and instead adds a new API:
select: Earlier API, unchanged. Returns the lowest-scoring (best) matching kernel from the catalog.collect_kernels: Returns a vector of entries, sorted by score. Also includes additional information in the form ofEvaluateAuxOutputand score, for later use.This also is the first step to simplifying
gen_desc_t, as theset_entryfunction sets bothaux_params_andentry, guaranteeing consistency in the state.