Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge-sort when sub/work group size is small #2002

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Fix merge-sort when sub/work group size is small #2002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4364762
Ensure `__max_sg_size` is at least 4 in sort
carbotaniuman Jan 16, 2025
45c84cf
Fix chunk calculation
dmitriy-sobolev Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge_sort.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,9 @@ struct __merge_sort_global_submitter<_IndexT, __internal::__optional_kernel_name
const _IndexT __n = __rng.size();
_IndexT __n_sorted = __leaf_size;
const bool __is_cpu = __q.get_device().is_cpu();
const _IndexT __chunk = __is_cpu ? 32 : 4;
// The chunk size must not exceed two sorted sub-sequences to be merged,
// ensuring that at least one work-item processes them.
const _IndexT __chunk = std::min<_IndexT>(__is_cpu ? 32 : 4, __n_sorted * 2);
const std::size_t __steps = oneapi::dpl::__internal::__dpl_ceiling_div(__n, __chunk);
bool __data_in_temp = false;

Expand Down
Loading