[oneDPL][doc] Know limitations: a minor change proposed #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MikeDvorskiy
commented
Apr 28, 2025
MikeDvorskiy
commented
- A minor change proposed. about move constructable for remove/remove_if/unique
- A wording about 'sort' issue with Intel® Arc™ graphics 140V
akukanov
reviewed
May 6, 2025
| @@ -166,7 +166,7 @@ Known Limitations | |||
| * For ``max_element``, ``min_element``, ``minmax_element``, ``partial_sort``, ``partial_sort_copy``, ``sort``, ``stable_sort`` | |||
| the dereferenced value type of the provided iterators should satisfy the ``DefaultConstructible`` requirements. | |||
| * For ``remove``, ``remove_if``, ``unique`` the dereferenced value type of the provided | |||
| iterators should be ``MoveConstructible``. | |||
| iterators should be ``CopyConstructible``. | |||
There was a problem hiding this comment.
Could you please point out to the place(s) in the code where copy construction is needed?
akukanov
reviewed
May 6, 2025
Comment on lines
+180
to
+181
| * ``sort``, ``stable_sort``, ``sort_by_key`` and ``stable_sort_by_key`` algorithms with a device policy are still not supported | ||
| on Windows with Intel® Arc™ graphics 140V. |
There was a problem hiding this comment.
Is this a temporary limitation or a "permanent" one? If we expect this to be resolved in reasonable time, the note should go into Release Notes, not into this document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.