Distributed size for concurrent ordered containers #1803
+108
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboyarinov
commented
Aug 4, 2025
| key_compare my_compare; | ||
| random_level_generator_type my_rng; | ||
| atomic_node_ptr my_head_ptr; | ||
| std::atomic<size_type> my_size; |
Contributor
Author
There was a problem hiding this comment.
There is also an option to keep my_size, reserve a flag bit in it and use it for optimizing consecutive calls to size() by saving the result of combine into my_size and marking it as "changed" in the insertion.
I did not investigate potential performance effects from CAS operations on my_size, just wanted to save the idea.
kboyarinov
requested review from
aleksei-fedotov,
dnmokhov,
isaevil and
vossmjp
phprus
reviewed
Nov 27, 2025
|
|
||
| void set_size(size_type size) { my_local_size.store(size, std::memory_order_relaxed); } | ||
| void increment_size() { | ||
| my_local_size.store(local_size() + 1, std::memory_order_relaxed); |
Contributor
There was a problem hiding this comment.
Why not use atomic std::atomic<>::fetch_add instead of load and store pair?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a comprehensive description of proposed changes
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information