Skip to content

Remove max_device_infos limit in riscv mux target #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

dlopr
Copy link
Contributor

@dlopr dlopr commented Jan 29, 2025

There was a harcoded maximum of devices used as static size for a std::array.

This removes the limit and uses a dynamically sized std::vector instead.

Copy link
Collaborator

@hvdijk hvdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The main idea looks good. Are you intending for it to still be possible to have invalid device info (in which case it will still need to be handled), or are you wanting to make that impossible?

There was a harcoded maximum of devices used as static size for a
std::array.

This removes the limit and uses a dynamically sized std::vector instead.
@dlopr dlopr force-pushed the fix-device-detection-2 branch from f3fb886 to 120ae08 Compare February 19, 2025 19:38
Copy link
Collaborator

@hvdijk hvdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hvdijk hvdijk merged commit 8778c39 into uxlfoundation:main Feb 20, 2025
12 checks passed
@dlopr dlopr deleted the fix-device-detection-2 branch April 24, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants