Ensure that expected fails on CTS always show as a pass. #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/ensure_cts_passes_known_fails
branch
10 times, most recently
from
feaeb4f to
3fab342
Compare
When we have regular fails which we do not expect an immediate fix, we want to show as pass so we can catch be failures more easily. When we know there is an expected fail, we create files to cover fails on all targets or fails on a particular target for OpenCL CTS and SYCL CTS. These will be under .github/opencl_cts and .github/sycl_cts. Fails files will be of the form expect_fail_all.csv or expect_fail_<target>.csv. These should match lines in the original csv file being used.
coldav
force-pushed
the
colin/ensure_cts_passes_known_fails
branch
from
3fab342 to
0dc9f30
Compare
coldav
changed the title
hvdijk
reviewed
Feb 5, 2025
alan-forbes-cp
approved these changes
Feb 5, 2025
hvdijk
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that expected fails on CTS always show as a pass.
Reason for change
When we have regular fails which we do not expect an immediate fix, we
want to show as pass so we can catch be failures more easily.
Description of change
When we know there is an expected fail, we create files to cover fails
on all targets or fails on a particular target for OpenCL CTS and
SYCL CTS. These will be under .github/opencl_cts and .github/sycl_cts.
Fails files will be of the form expect_fail_all.csv or expect_fail_.csv.
These should match lines in the original csv file being used.