-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix version switcher code and update URLs and logos #2279
DOC: Fix version switcher code and update URLs and logos #2279
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. But to see the final version switcher working with all the versions, I guess we need to merge this PR first and see it on gh-pages branch?
That was already done - the artifacts built from the source code in this PR (minus the entry for 2025.2 and the updated logos) were already deployed in a previous PR to 'gh-pages': You'll see there that the version switcher is working there: |
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
PR extracting a subset from this one:
#2214
(without the GH action, just the source code)
It includes required changes to make new doc builds work correctly with the custom version switcher. These were already incorporated here:
#2274
In addition to the source code changes, it also updates the custom logos to use the ones from UXL foundation, taken from here:
https://github.com/uxlfoundation/uxlfoundation.org/tree/main/images
Note: this is hard-coding a
versions.json
file, but that file should ideally later on get built programmatically according to what's available.Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.