Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: trigger doc build on release tag #2301
feature: trigger doc build on release tag #2301
Changes from all commits
1dc8c52
ee953a5
33710a5
73c40e0
f0ca811
8452ecc
a874c91
6769c6f
bf977b0
f0934d5
d27c18f
8cd871d
c0f7dd4
7cdb5c8
2989c14
c3e3bc0
ed36ec8
3717eb3
4637d83
fe1fe57
71572e9
958f7ae
3d4b7c1
1cf77af
b3d906b
334782b
2e271ba
e009d6b
42a7cf2
55814c3
b6e7017
6cc5f1b
d059818
e66e7d0
7bdf509
468dabe
3086f0f
f059967
bbc9f0f
36408eb
619f28b
e5f5f76
23a5ed3
2cb0892
fcf3d2c
beb61dd
bf709bc
dae0aef
8324337
91f24bb
ce941e6
1886f2e
dd2c91a
0e5152a
0520d26
c7783c2
0706bd5
709f425
b41003d
1563665
ab1c9fd
e489519
d062b68
01c6612
a1a1623
c70d592
e0a1e99
5ff8ac8
13d531f
87235c1
a4fc3b1
1f793ea
2dc2a88
0aa23eb
4e0a3b9
113bed7
c533711
ffa3733
3198542
3cdb5f6
d781667
68b621d
91e54d2
4ad3fd1
7fd43ba
99182a5
3623e34
c82b91a
f706a82
e3dfaf6
6c9d22a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: divergence from docs CI by having the --gh-pages flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's because they do slightly different things. This one with
--gh-pages
uses different build options and generates a versioned folder - simply reusing the result from the docs CI and renaming it results in docs that don't render when put under gh-pages.But that shouldn't be a problem because in the end both of them are using the same software to build the docs, with the same pinned versions from
requirements-doc.txt
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This run call is 57 lines long, ideally it should be a separate shell script located in .github/scripts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved now I have a doc_release.sh in scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the impression that the scripts were meant to be executable both locally and on GH.
This script would mostly be about git commands which are specific to this particular workflow and not reusable elsewhere. I think it makes sense to keep it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alexsandruss @homksei please weigh in on this, as we are both inferring about the rules of the codebase when it comes to this topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-cortes-intel As far as I see, the script is a general deployment script which the only git commands which are specific to github is the setting the username and email, which could be maintained in the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that sounds like a reasonable split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the suggestions! Moved git config back to yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this number come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched git config and there is a .cache/per-commit/repondmp4e6s/workflows/main.yml so I tried to jsut copy it over, need this config to push the changes