-
Notifications
You must be signed in to change notification settings - Fork 182
update: update algorithm and preview #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update: update algorithm and preview #2354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. see 54 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also missing some details about specifics of support - for example, for TSNE, it only works with n_components=2
.
doc/sources/algorithms.rst
Outdated
@@ -100,6 +100,12 @@ Regression | |||
- ``normalize`` != `False` | |||
- ``sample_weight`` != `None` | |||
- Only dense data is supported. | |||
* - `IncrementalLinearRegression` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a scikit-learn estimator and the top of the doc mentions "the following sklearn estimators", so shouldn't be listed here. Docs about what it supports could be moved to its docstrings, or to a new section at the end of this doc.
Same for the other incremental algorithms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! Removed all incremental algos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the limitations in what they support to their docstrings.
Also appears to be missing some algorithms like ExtraTrees. |
Added! thx |
Not related to the aim of this PR, but I'm thinking it'd be nice to have the classes listed here offer clickable links to the sklearn docs. Since we have intersphinx with sklearn confgured on it, it could be done with something like this:
or
|
This PR updates the sklearnex doc with new features implemented in past year
PR completeness and readability
Testing
Performance