Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

The .yaml file for conda builds had removed catboost and shap as a test dependencies due to not working with numpy>=2. By now, the latest releases of both of those packages in conda-forge work with numpy>=2, so they can be added back as it says in the TODO line.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

Performance

Not applicable.

@david-cortes-intel david-cortes-intel added infra testing Tests for sklearnex/daal4py/onedal4py & patching sklearn labels Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 79.87% <ø> (ø)
github 71.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@icfaust
Copy link
Contributor

icfaust commented Apr 24, 2025

something is funky with the windows conda recipe numpy versioning with catboost :(

@david-cortes-intel
Copy link
Contributor Author

@Alexsandruss Alexsandruss merged commit b1f312a into uxlfoundation:main Apr 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra testing Tests for sklearnex/daal4py/onedal4py & patching sklearn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants