MAINT: Remove untested option to build without onedal module#2916
Open
david-cortes-intel wants to merge 2 commits intouxlfoundation:mainfrom
Open
MAINT: Remove untested option to build without onedal module#2916david-cortes-intel wants to merge 2 commits intouxlfoundation:mainfrom
david-cortes-intel wants to merge 2 commits intouxlfoundation:mainfrom
Conversation
david-cortes-intel
requested review from
ethanglaser,
icfaust and
napetrov
as code owners
david-cortes-intel
requested review from
Vika-F,
maria-Petrova,
syakov-intel and
yuejiaointel
as code owners
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
/intelci: run |
Contributor
|
#1744 for traceability. Worth an discussion @david-cortes-intel. possibly an issue should be created. thoughts @napetrov ? |
ethanglaser
approved these changes
Feb 2, 2026
Contributor
|
Oops, approved before reading discussion. If fujitsu uses this flag we should not remove it |
Contributor
|
Nothing other than further digging this |
Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com>
Contributor
|
@rakshithgb-fujitsu @theComputeKid could you please take a look at "OFF_ONEDAL_IFACE" option removal? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a build option to compile the library without the
onedalmodule, and some code paths have fallbacks for this that involve daal4py, but such fallbacks are not tested, and thesklearnexmodule by this point is not intended to be used without theonedalmodule.This PR removes such option along with the fallback, and updates the documentation to reflect the new minimum oneDAL C++ version required.
Checklist:
Completeness and readability
Testing