Skip to content

Add array_api_dispatch to spmd validation scope#2940

Draft
ethanglaser wants to merge 3 commits intouxlfoundation:mainfrom
ethanglaser:dev/eglaser-spmd-array-api-testing
Draft

Add array_api_dispatch to spmd validation scope#2940
ethanglaser wants to merge 3 commits intouxlfoundation:mainfrom
ethanglaser:dev/eglaser-spmd-array-api-testing

Conversation

@ethanglaser
Copy link
Contributor

Description


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser
Copy link
Contributor Author

/intelci: run

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onedal/_device_offload.py 25.00% 2 Missing and 1 partial ⚠️
Flag Coverage Δ
azure 78.67% <25.00%> (?)
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/_device_offload.py 71.83% <25.00%> (-10.97%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel
Copy link
Contributor

The CI error:

FAILED spmd/decomposition/tests/test_pca_spmd.py::test_pca_spmd_synthetic[False-True-float64-dpnp-SyclQueue_GPU-False-None-100-10000] - TypeError: An array must be any of supported type, but got <class 'numpy.ndarray'>

@david-cortes-intel
Copy link
Contributor

@ethanglaser Could you merge #2906 here to verify that the combination of both solves the CI issue?

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser
Copy link
Contributor Author

/intelci: run

yuejiaointel added a commit to yuejiaointel/scikit-learn-intelex that referenced this pull request Feb 11, 2026
yuejiaointel added a commit to yuejiaointel/scikit-learn-intelex that referenced this pull request Feb 12, 2026
@david-cortes-intel
Copy link
Contributor

The new error, this time in logistic regression SPMD:

TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.asnumpy()` to construct a NumPy array explicitly

@ethanglaser
Copy link
Contributor Author

The new error, this time in logistic regression SPMD

Errors in kmeans and logreg are expected. This PR will not be merged until those array API updates are complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants