Skip to content

[maintenance] Remove onedal/sklearnex functionality mixing in KNeighborsClassifier.predict using from_table#3228

Draft
icfaust wants to merge 7 commits into
uxlfoundation:mainfrom
icfaust:dev/neighbors_fix_0
Draft

[maintenance] Remove onedal/sklearnex functionality mixing in KNeighborsClassifier.predict using from_table#3228
icfaust wants to merge 7 commits into
uxlfoundation:mainfrom
icfaust:dev/neighbors_fix_0

Conversation

@icfaust
Copy link
Copy Markdown
Contributor

@icfaust icfaust commented Jun 2, 2026

Description

KNeighborsClassifier uses the onedal from_table functionality and internal parameter setting functionality in a way which is different from the rest of the codebase. This makes it similar to all other uses in the codebase. This is not a final solution, as a refactoring of the _get_onedal_params needs to be done, and therefore includes a temporary (but limited) solution.

Follow up: evaluate how to use a _create_model function in the classifier, as a model is available for this specific estimator (allowing for the definition of a _create_model function).


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant