[maintenance] Remove onedal/sklearnex functionality mixing in KNeighborsClassifier.predict using from_table#3228
Draft
icfaust wants to merge 7 commits into
Draft
[maintenance] Remove onedal/sklearnex functionality mixing in KNeighborsClassifier.predict using from_table#3228icfaust wants to merge 7 commits into
KNeighborsClassifier.predict using from_table#3228icfaust wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
KNeighborsClassifieruses the onedalfrom_tablefunctionality and internal parameter setting functionality in a way which is different from the rest of the codebase. This makes it similar to all other uses in the codebase. This is not a final solution, as a refactoring of the_get_onedal_paramsneeds to be done, and therefore includes a temporary (but limited) solution.Follow up: evaluate how to use a _create_model function in the classifier, as a
modelis available for this specific estimator (allowing for the definition of a_create_modelfunction).Checklist:
Completeness and readability
Testing
Performance