Fix the feature location checks in Frame::checkKeyPoints#107
Open
kartikmohta wants to merge 1 commit into
Open
Fix the feature location checks in Frame::checkKeyPoints#107kartikmohta wants to merge 1 commit into
kartikmohta wants to merge 1 commit into
Conversation
|
Is there a reason this hasn't been merged? The changes look correct to me if the intent is to have the keypoints in the four quadrants as far away as possible squarely from the center. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like a fix for a different problem 3ba0993 led to some wrong checks being introduced into the code.