Bug Fixes #2
Open
Bug Fixes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in set_facing where newly spawned objects would not correctly set x scale of the $Flip node due to trying to use the flip variable, which is an onready var that is not ready at this point.
Author
|
I realized in hindsight you could get_node_or_null("Flip") on line 583 instead of $Flip directly, but considering BaseObj.tscn always has a Flip node, I didn't bother to figure out how to edit the commit |
Fixes an editor bug where the collisionbox plugin constantly complains about ThrowBox not having editor_selected
uzkbwza
reviewed
Nov 1, 2024
Owner
uzkbwza
left a comment
uzkbwza
left a comment
There was a problem hiding this comment.
i have tool disabled on this script because of a nasty bug in 3.5.1. i think if it is enabled and i add more fields to the hitbox class, it breaks all the fields for every single throw in all open scenes.
Author
|
Did you want me to re-remove it from this PR? |
Author
|
I originally made this PR for the set_facing inside BaseObj.spawn_object fix, and didn't realize that editing another file would retroactively update this PR, anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in set_facing where newly spawned objects would not correctly set x scale of the $Flip node due to trying to use the flip variable, which is an onready var that is not ready at this point.
Otherwise, before this fix, what happens is when you try to spawn_object, the game is supposed to automatically call
obj.set_facing(get_facing_int), which it correctly does mechanically, but the visuals do not match this behavior except in predictions on later turnsDemonstration of the issue this is trying to fix:
demonstration.mp4