等待解决方案,详见 PR #399#399
Open
IceCodeNew wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Fix #398 |
Contributor
|
用 因为有个网站叫 gfw ,并且存在伊朗的墙 |
Collaborator
Author
可以,标签名称只是沿用 #390 的例子而已 |
dac7abb to
e81c368
Compare
Contributor
|
这样写 我个人跑了一下代码没发现这样写会有什么问题,可以再重新测试一下看看。 |
Collaborator
Author
我主要是担心万一有解析实现比较有问题,把 |
Contributor
|
个人倾向删 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
首先
services.googleapis.cn这个域名会被domain:cn这条记录兜底,所以在我看来解决问题的思路只有一种,那就是标记这个域名进黑名单(e.g.@gfw)。以此来保证下游代理软件使用本项目的规则时,会代理这个域名。我不希望改变
domain:googleapis.cn的标记,正如 Issue #398 里的检测结果展示的那样,应该可以认定这个域名及其子域名的记录都是国内的 IP。所以这就导致合理的标记
services.googleapis.cn的结果变成这样:这样的域名记录目前无法被 geosite.dat 的生成过程很好地处理,所以期待社区其他人的建议。