Skip to content

[MLRun] Fix alerts labels + API communication#1058

Merged
liranbg merged 4 commits intov3io:developmentfrom
moranbental:alerts
Feb 13, 2025
Merged

[MLRun] Fix alerts labels + API communication#1058
liranbg merged 4 commits intov3io:developmentfrom
moranbental:alerts

Conversation

@moranbental
Copy link
Member

@moranbental moranbental commented Feb 11, 2025

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove irrelevant fields.]

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])

Description

  1. Use the alert labels component correctly.
  2. Allow worker replicas to be 0 when alerts are enabled.
  3. Change API communication:
  • When there are no workers, pass communication through the chief.
  • When there is 1 worker, pass communication through worker/chief.
  • When there are 2 or more workers, pass communication through the workers only.

https://iguazio.atlassian.net/browse/ML-8888
https://iguazio.atlassian.net/browse/ML-9029

@moranbental moranbental marked this pull request as draft February 11, 2025 12:26
@moranbental moranbental changed the title [MLRun] Fix alerts labels + worker replicas [MLRun] Fix alerts labels + API communication Feb 12, 2025
@moranbental moranbental marked this pull request as ready for review February 12, 2025 09:33
@liranbg liranbg merged commit 4ceb670 into v3io:development Feb 13, 2025
22 checks passed
@moranbental moranbental deleted the alerts branch February 13, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants