[MLRun] Add ingressClassName to Ingress manifests#1059
Merged
alexpirogovski merged 1 commit intov3io:developmentfrom Feb 12, 2025
Merged
[MLRun] Add ingressClassName to Ingress manifests#1059alexpirogovski merged 1 commit intov3io:developmentfrom
alexpirogovski merged 1 commit intov3io:developmentfrom
Conversation
alexpirogovski
changed the title
liranbg
approved these changes
Feb 12, 2025
Collaborator
liranbg
left a comment
liranbg
left a comment
There was a problem hiding this comment.
bump chart version as well
alexpirogovski
force-pushed
the
add_ingressClassName
branch
from
b7af331 to
d948b08
Compare
alexpirogovski
force-pushed
the
add_ingressClassName
branch
from
d948b08 to
205dff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove irrelevant fields.]
[mychartname])Description
Since the ingressClass steering through annotations is deprecated, the ingressClassName field is now added to Ingress templates and exposed via Values to set the desired ingressClass. Default is an empty string for compatibility.