[Framework] Resolve race condition in cache during parallel set operations#72
Merged
TomerShor merged 1 commit intov3io:developmentfrom Jun 25, 2025
Conversation
rokatyy
requested changes
Jun 25, 2025
Collaborator
rokatyy
left a comment
rokatyy
left a comment
There was a problem hiding this comment.
Nice catch!
Please add test to verify that :)
Collaborator
Author
I updated the Description and linked the unit tests PR. |
rokatyy
approved these changes
Jun 25, 2025
rokatyy
approved these changes
Jun 25, 2025
TomerShor
approved these changes
Jun 25, 2025
TomerShor
pushed a commit
that referenced
this pull request
Jun 29, 2025
This PR adds unit tests for the flow described in the related Jira ticket: https://iguazio.atlassian.net/browse/NUC-455 . The tests ensure coverage of the newly implemented logic and validate its behavior under expected conditions. In addition, this PR includes test coverage for the changes introduced in [#72](#72), providing verification for that logic as well. The unit tests failure are fixed in a separated PR - #72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Described in the jira - https://iguazio.atlassian.net/browse/NUC-494
Root Cause
The problem happens when multiple goroutines run
Load()→NewSafeTrie()→Store()at the same time. Each one might create its own trie, and since Store() always overwrites the value, one goroutine can replace the result of another—causing entries to be lost.Description
Replace
Load/Storepattern with the atomicLoadOrStore()to ensure only one goroutine creates the initial trie per host.Affected Areas
No affected areas, internal package changes only
Testing
Changes Made