Skip to content

[Dependencies] Bump Go version #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomerShor merged 4 commits into from
Jan 15, 2026
Merged

[Dependencies] Bump Go version #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8efd1e
Bump go version to 1.25.5
weilerN Jan 14, 2026
30ac023
Update golangci.yml
weilerN Jan 14, 2026
c6b4e89
Update go version in dockerfiles
weilerN Jan 14, 2026
8228da8
Update lint version in makefile
weilerN Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 21 additions & 31 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,44 +12,34 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
version: "2"

# timeout for analysis
timeout: 5m
linters:
disable-all: true
default: none
enable:
- errcheck
- goconst
- gofmt
- revive
- gosimple
- gocritic
- govet
- ineffassign
- misspell
- staticcheck
- unconvert
- govet
- unused
- errcheck
- typecheck
- gocritic
- gci

run:

# timeout for analysis
timeout: 5m

linters-settings:
gci:
sections:
- standard
- prefix(github.com/v3io/scaler)
- default
- blank
- dot

custom-order: true

issues:

# List of regexps of issue texts to exclude
exclude:
- "comment on"
- "error should be the last"
- "should have comment"
formatters:
enable:
- gci
- gofmt
settings:
gci:
sections:
- standard
- prefix(github.com/v3io/scaler)
- default
- blank
- dot
custom-order: true
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ push-docker-images:

# tools get built with the specified OS/arch and inject version
GO_BUILD_TOOL_WORKDIR = /scaler
GOLANGCI_LINT_VERSION := v1.64.6
GOLANGCI_LINT_VERSION := v2.7.2

.PHONY: lint
lint: modules
Expand Down
2 changes: 1 addition & 1 deletion cmd/autoscaler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#

FROM gcr.io/iguazio/golang:1.23.8-alpine AS builder
FROM gcr.io/iguazio/golang:1.25-alpine AS builder

RUN apk --update --no-cache add \
git \
Expand Down
2 changes: 1 addition & 1 deletion cmd/dlx/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#

FROM gcr.io/iguazio/golang:1.23.8-alpine AS builder
FROM gcr.io/iguazio/golang:1.25-alpine AS builder

RUN apk --update --no-cache add \
git \
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/v3io/scaler

go 1.23.8
go 1.25.5

require (
github.com/dghubble/trie v0.1.0
Expand Down
2 changes: 1 addition & 1 deletion test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#

FROM gcr.io/iguazio/golang:1.23.8
FROM gcr.io/iguazio/golang:1.25

ARG DOCKER_CLI_VERSION="28.0.4"

Expand Down