Handle status code infinite loop#162
Merged
TomerShor merged 6 commits intov3io:developmentfrom Dec 23, 2025
Merged
Conversation
TomerShor
reviewed
Dec 18, 2025
Collaborator
TomerShor
left a comment
TomerShor
left a comment
There was a problem hiding this comment.
Looks good!
Added some suggestions
pkg/common/helper.go
Outdated
Comment on lines
190
to
192
| checkFunctions := []func(error) bool{ | ||
| matchErrorString, | ||
| matchErrorStatusCode, |
Collaborator
There was a problem hiding this comment.
make the intent of each function more explicit and improve code readability:
Suggested change
| checkFunctions := []func(error) bool{ | |
| matchErrorString, | |
| matchErrorStatusCode, | |
| nonFatalErrorChecks := []func(error) bool{ | |
| isNonFatalErrorString, | |
| isNonFatalStatusCode, |
Contributor
Author
There was a problem hiding this comment.
Fixed here - CR 1 - namings and docstring
rokatyy
approved these changes
Dec 22, 2025
Contributor
rokatyy
left a comment
rokatyy
left a comment
There was a problem hiding this comment.
Minor comments, otherwise approved ✅
pkg/common/helper.go
Outdated
| } | ||
|
|
||
| // isNonFatalErrorString checks whether the error message contains any of the predefined non-fatal substrings | ||
| func isNonFatalErrorString(e error) bool { |
Contributor
There was a problem hiding this comment.
Suggested change
| func isNonFatalErrorString(e error) bool { | |
| func isNonFatalErrorString(err error) bool { |
pkg/common/helper.go
Outdated
| } | ||
|
|
||
| // isNonFatalStatusCode checks whether the error contains any of the predefined non-fatal HTTP status codes | ||
| func isNonFatalStatusCode(e error) bool { |
Contributor
There was a problem hiding this comment.
Suggested change
| func isNonFatalStatusCode(e error) bool { | |
| func isNonFatalStatusCode(err error) bool { |
pkg/common/helper.go
Outdated
| "dialing to the given TCP address timed out", | ||
| "timeout", | ||
| "refused", | ||
| nonFatalErrorChecks := []func(error) bool{ |
Contributor
There was a problem hiding this comment.
Suggested change
| nonFatalErrorChecks := []func(error) bool{ | |
| nonFatalErrorCheckFunctions := []func(error) bool{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change improves non-fatal engine error detection by complementing the existing string-based logic with HTTP status-code awareness.
Errors that expose an HTTP status code (e.g. V3IO errors) are now handled explicitly, allowing transient failures such as
HTTP 503 (Service Unavailable)to be classified correctly and retried. The logic safely unwraps nested errors and preserves existing behavior.🛠️ Changes Made
EngineErrorIsNonFatalto support multiple error-matching strategies.🧪 Testing
🔗 References