-
Notifications
You must be signed in to change notification settings - Fork 212
Usage statistics info and opt-out #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language Review
|
|
||
to `false`. | ||
|
||
Follow the instructions in https://github.com/vaadin/vaadin-usage-statistics[usage statistics collector repository] to disable usage statistics on the client-side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vaadin-usage-statistics
component is imported by default (at least in development mode). If I read this first time, my first assumption would be that setting vaadin.devmode.usageStatistics.enabled
or VAADIN_USAGE_STATS_ENABLED
would automatically also stop importing vaadin-usage-statistics
(or disable it) automatically.
Now disabling requires two steps. And seems that the instructions in vaadin-usage-statistics
regarding global disabling with a script is broken.
And additionally Flow projects may not have package.json
to put disableUsageStatistics
flag. Which would make opting-out not possible by following the current instruction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it in steps: add the server-side opt-out docs and option for environment variables, then take a look at the client-side parameter, what is broken and add docs later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I removed the mention about vaadin-usage-statistics
so far to unblock vaadin/flow#21217.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure it can be done in steps. Also disabling telemetry on server side should ideally also remove or disable vaadin-usage-statistics
automatically. That should be also one step.
Remove instructions for disabling client-side usage statistics.
Provides general info about usage statistics and ways to opt-out.
Related-to vaadin/flow#21217