Skip to content

Conversation

@sissbruecker
Copy link
Contributor

Adds the Themes article for the new styling docs.

Note

The PR targets a base branch for the new styling docs. That branch has the old styling docs removed and new articles are added gradually until the new section is ready. Cross-references between new articles will be filled in later, respective sections have been marked with TODOs.

@sissbruecker sissbruecker requested a review from vursen November 12, 2025 07:45
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

AI Language Review

The following issues require improvement in the Themes and Base Styles file:

  1. Under "Aura Theme":

    • The closing bracket of the image caption for "Login form using the Aura theme" is incorrect. It should be image::_images/aura-theme.png[Login form using the Aura theme, width=50%] instead of image::_images/aura-theme.png[[Login form using the Aura theme, width=50%].
  2. Under "Lumo Theme":

    • The descriptions and instructions for the Aura and Lumo themes are largely repetitive. Consider restructuring to avoid duplication by summarizing common instructions and only highlighting differences between the themes.
  3. General:

    • Consistent usage of CSS comments is important. Currently, the CSS code snippets show inconsistent commenting for custom styles. It is recommended to use a uniform commenting style across all CSS blocks, providing context where necessary.

@sissbruecker sissbruecker marked this pull request as draft November 12, 2025 12:53
@sissbruecker
Copy link
Contributor Author

sissbruecker commented Nov 12, 2025

Applying light + dark theme using Lumo needs more work.

Edit: Updated the Lumo section to recommend adding theme="dark" to the generated index.html.

@sissbruecker sissbruecker marked this pull request as ready for review November 12, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants