Start REST service via embedded HttpServer #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
2cn8zm-codex/implement-fix-for-eclipse-plugin-issue-2
branch
from
3683576 to
eb71b46
Compare
Artur-
force-pushed
the
2cn8zm-codex/implement-fix-for-eclipse-plugin-issue-2
branch
from
eb71b46 to
c30eb20
Compare
|
In general REST service is being started. But it should only be started when Vaadin project is detected, same as in VS Code. Project detection issue -> #18 |
|
Is it important that it is started only in case there is a Vaadin project detected? It sounds like a lot of logic for little gain? |
Not necessarily, user can always start/stop plugin to control rest server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
Summary
CopilotRestServicewith JDKHttpServerActivatorto start and stop the new servercom.sun.net.httpserverTesting
mvn -q test(fails: command not found)https://chatgpt.com/codex/tasks/task_b_68590a225680833380c4f7f91cedb78a