fix: Fix undo/redo functionality and tests in Maven/Tycho environment #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that when running tests via Maven/Tycho, the Eclipse workspace context (IUndoContext) was not properly initialized. This caused the undo operations to fail because they couldn't find the matching context. Changes made: - Update recordOperation to properly add operations to history with context - Fix operation contexts to use workspace undo context - Update tests to match REST service behavior (apply changes before recording) - Add proper context management in CopilotFileEditOperation - Created a custom WorkspaceUndoContext class to use when the default workspace context is not available (common in test environments) - Made the custom context a singleton to ensure consistency across operations - Updated getOrCreateWorkspaceContext() to fall back to the custom context - All undo/redo operations now use the same consistent context This allows tests to pass both when run in Eclipse IDE and via Maven CLI. All 15 undo/redo tests (10 in CopilotUndoManagerTest + 5 in BinaryFileUndoRedoTest) are now passing. Co-Authored-By: Claude <[email protected]>
manolo
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that when running tests via Maven/Tycho, the Eclipse workspace context (IUndoContext) was not properly initialized. This caused the undo operations to fail because they couldn't find the matching context.
Changes made:
This allows tests to pass both when run in Eclipse IDE and via Maven CLI. All 15 undo/redo tests (10 in CopilotUndoManagerTest + 5 in BinaryFileUndoRedoTest) are now passing.