feat: allow user to set the groupId when creating a new project #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolo
force-pushed
the
feat/groupId
branch
2 times, most recently
from
e090b30 to
2f7d5e8
Compare
Summary of Modifications - HelloWorldProjectModel: - Fixed the groupId handling in getDownloadUrl() by replacing the hardcoded value with the value set via the model's setter. The groupId in the generated URL now correctly reflects user input from the wizard. - Tests for groupId handling: - HelloWorldProjectModelTest: Added testCustomGroupIdInUrl to verify that setting a custom groupId is properly reflected and URL-encoded in the generated download URL. - StarterProjectModelTest: Added testCustomGroupIdInUrl to ensure the same groupId handling is tested for starter projects. related to: vaadin/copilot#96
manolo
force-pushed
the
feat/groupId
branch
from
20bde00 to
1fcbd8b
Compare
|
Artifact build on last commit: repository.zip. |
|
Group id setting works, but again same remark as in case of vs code - why project name has been limited not to contain spaces? 
|
MarcinVaadin
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Modifications
Feature:
HelloWorldProjectModel: Fixed the groupId handling in getDownloadUrl() by replacing the hardcoded value with the value set via the model's setter. The groupId in the generated URL now correctly reflects user input from the wizard.Tests:
HelloWorldProjectModelTest: Added testCustomGroupIdInUrl to verify that setting a custom groupId is properly reflected and URL-encoded in the generated download URL.StarterProjectModelTest: Added testCustomGroupIdInUrl to ensure the same groupId handling is tested for starter projects.Other changes:
- Align defaults with other plugins by setting them to
NewProjectandcom.example.application- Align validations with other plugins
related to: vaadin/copilot#96