Skip to content

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 12, 2025

  • Fixed hardcoded forward slash when extracting filename from classpath entry
  • Now checks for both forward slash and backslash to work on all platforms
  • This was causing Vaadin dependency detection to fail on Windows
  • Other path handling in the plugin uses proper platform-independent APIs

@Artur- Artur- requested a review from MarcinVaadin September 12, 2025 13:19
MarcinVaadin
MarcinVaadin previously approved these changes Sep 12, 2025
Copy link
Member

@MarcinVaadin MarcinVaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get that comment

// Use File.separator for platform independence, but IPath always uses '/'

but solution might work

@Artur- Artur- marked this pull request as draft September 12, 2025 13:23
@Artur-
Copy link
Member Author

Artur- commented Sep 12, 2025

Let's see if CI testing can find this issue first

@Artur- Artur- closed this Sep 12, 2025
@Artur- Artur- reopened this Sep 12, 2025
@manolo
Copy link
Member

manolo commented Sep 16, 2025

Why is this still in draft?
Shouldn't this include a test ?, seems like the one in https://github.com/vaadin/eclipse-plugin/pull/65/files ?

@Artur-
Copy link
Member Author

Artur- commented Sep 16, 2025

It was not clear if this was a real issue or not - it was only discovered by Claude

Artur- and others added 2 commits September 17, 2025 19:28
- Fixed hardcoded forward slash when extracting filename from classpath entry
- Now checks for both forward slash and backslash to work on all platforms
- This was causing Vaadin dependency detection to fail on Windows
- Other path handling in the plugin uses proper platform-independent APIs
- Add test to verify Windows-style paths with backslashes are correctly handled
- Add test to ensure non-existent projects return valid empty structures
- These tests validate the fix from commit ddc06c2 that resolved NullPointerException issues

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

Artifact build on last commit: repository.zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants