Remove Hilla framework support from new project wizard #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all Hilla-related functionality from the Eclipse plugin's new project wizard to simplify the codebase and focus on Flow framework only. Changes: - Removed Hilla checkbox from Starter Project wizard UI - Removed Hilla option from Hello World project framework selection - Updated StarterProjectModel to remove includeHilla field and methods - Simplified URL generation to only support Flow framework - Updated validation logic to remove Hilla-specific constraints - Updated documentation to remove Hilla references - Updated all test cases to remove Hilla-related assertions All tests pass successfully (19 tests, 0 failures). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Since Hilla has been removed, the framework selection combo in the Hello World project wizard now only had a single option (Flow). This commit removes the unnecessary framework selection UI element as Flow is now the only and default framework. Changes: - Removed frameworkCombo field from VaadinProjectWizardPage - Removed framework selection UI from Hello World wizard options - Removed framework combo listener registration Framework is hardcoded to "flow" in getProjectModel() method. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Artifact build on last commit: repository.zip. |
mgarciavaadin
approved these changes
Nov 14, 2025
mgarciavaadin
left a comment
mgarciavaadin
left a comment
There was a problem hiding this comment.
Would make sense to remove also the "Pure Java" option?
I think it can be confusing for users. Otherwise we should add an explanation about option for typescript views etc... something that explains why there is a "Pure Java" option
mgarciavaadin
requested changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all Hilla framework support from the Eclipse plugin's new project wizard, simplifying the codebase to focus exclusively on Vaadin Flow.
Changes Made
UI Changes:
Model Changes:
includeHillafield and related getter/setter methods fromStarterProjectModelHelloWorldProjectModelto remove Hilla comment referenceValidation Logic:
Documentation:
Tests:
StarterProjectModelTestto remove Hilla-related test casesHelloWorldProjectModelTestto use Flow instead of HillaTest Results
✅ All tests pass (19 tests, 0 failures)
Impact
🤖 Generated with Claude Code