fix: prevent unnecessary viewport update on VirtualList first render #8095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VirtualList connector was initializing lastRequestedRange to [0, 0], causing an unnecessary viewport range update on first render. This update would reload list items, destroying any focused elements and causing focus loss. Changed initialization to null to properly detect the first request and avoid spurious updates that interfere with focus management in master-detail views. Fixes the issue where focusing the first item only worked on the second attempt due to the list being unnecessarily reloaded on first render. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Artur-
force-pushed
the
virtual-list-initial-range
branch
from
cf2102b to
ee6be33
Compare
|
ugur-vaadin
reviewed
Oct 21, 2025
Contributor
ugur-vaadin
left a comment
ugur-vaadin
left a comment
There was a problem hiding this comment.
It seems that the tests also pass without the fix. Also, the focus ring does not seem to be there after resetting the list.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VirtualList connector was initializing lastRequestedRange to [0, 0], causing an unnecessary viewport range update on first render. This update would reload list items, destroying any focused elements and causing focus loss.
Changed initialization to null to properly detect the first request and avoid spurious updates that interfere with focus management in master-detail views.
Fixes the issue where focusing the first item only worked on the second attempt due to the list being unnecessarily reloaded on first render.