fix: fire response complete on empty responses#9215
Merged
ugur-vaadin merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
tomivirkki
approved these changes
Apr 29, 2026
b3f6166 to
6109515
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
A turn that produces no visible text — typically a tool-only turn where the model emits tool calls and stops without commentary — is still a successful exchange. But the response-complete lifecycle hooks were skipped: both the application-facing
ResponseCompleteListener.onResponseCompleteand the controller-facingAIController.onResponseCompletewere gated behind a non-empty-text check. Controllers that flush their pending UI state inonResponseComplete(e.g.ChartAIControllerapplying its pending query) never render on these turns; application listeners miss the completion entirely.This PR moves both hook invocations out of the non-empty-text gate so every successful exchange fires them, with the firing cadence unchanged (still once per user prompt, not per tool call or round-trip). The
conversationHistoryadd stays gated to avoid polluting history with empty assistant entries.Type of change
Checklist