fix: validate all detected commercial components for Hilla apps #21914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During frontend build only npm packages imported by Java classes are validate by the license checker. However, for apps with Hilla views the check is skipped for packages imported only by frontend views. This change forces validation for all detected commercial components if the application is using Hilla views.
|
Test Results1 237 files ±0 1 237 suites ±0 1h 15m 33s ⏱️ + 1m 22s Results for commit e859bcf. ± Comparison against base commit ec7a322. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
github-project-automation
bot
moved this to 🔎Iteration reviews
in Vaadin Flow ongoing work (Vaadin 10+)
tltv
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During frontend build only npm packages imported by Java classes are validate by the license checker. However, for apps with Hilla views the check is skipped for packages imported only by frontend views. This change forces validation for all detected commercial components if the application is using Hilla views.