chore: replace glob package with Node.js built-in glob #22417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, nice idea! However, the implementation seems to be incomplete because theme plugin apparently doesn't copy assets files. |
Replace the external glob package dependency with Node.js built-in globSync functionality (available since Node.js 22). Changes: - Remove glob dependency from 3 package.json files - Update imports from 'glob' to 'node:fs' in theme plugins - All glob usage patterns are compatible with built-in implementation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove glob from devDependencies in the default frontend dependencies package.json.
Node.js built-in fs.globSync doesn't support the 'nodir' option from the glob package. Replace it with the 'exclude' option using statSync to filter out directories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…ctories The exclude callback in fs.globSync receives relative path segments during pattern matching, not full paths. Calling statSync() on these segments fails with ENOENT errors because they don't exist relative to the current working directory. Using withFileTypes: true returns Dirent objects that already contain type information via isDirectory(), avoiding the need for additional statSync() calls. This is both correct and efficient. Fixes asset copying from theme.json (FontAwesome icons, Line Awesome, etc.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Complete the migration from glob package to Node.js built-in fs.globSync by replacing the unsupported nodir option with withFileTypes + filtering. While the *.css pattern wouldn't match directories anyway, this ensures consistency across all globSync usage and fully completes the migration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Filter out any Dirent entries that don't have parentPath defined. If parentPath is undefined, we can't construct a valid file path anyway, so it makes more sense to filter those entries out early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the external glob package dependency with Node.js built-in globSync functionality (available since Node.js 22).
Changes: