ci: build base version locally for reliable API diff comparison #22697
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API diff workflow previously downloaded the base version from Maven repositories, which could contain stale or incorrect snapshots. This led to inaccurate API comparisons. Changes: - Clone and build the base branch in a separate directory - Install base artifacts to local Maven repository - Compare PR changes against locally-built base artifacts - Clean up base build directory after comparison This ensures API diff always compares against the actual state of the target branch, providing reliable and reproducible results regardless of what exists in remote Maven repositories.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API diff workflow previously downloaded the base version from Maven repositories, which could contain stale or incorrect snapshots. This led to inaccurate API comparisons.
Changes:
This ensures API diff always compares against the actual state of the target branch, providing reliable and reproducible results regardless of what exists in remote Maven repositories.