Skip to content

Conversation

@mcollovati
Copy link
Collaborator

Implements hotswap for changes related to the StyleSheet annotation. Reacts on adding, removing or updating the value of the annotation on AppShellConfigurator and Component subclasses, by registering or unregistering the stylesheet with the API provided by UI and UIInternals classes

Fixes #22631

Implements hotswap for changes related to the StyleSheet annotation.
Reacts on adding, removing or updating the value of the annotation
on AppShellConfigurator and Component subclasses, by registering
or unregistering the stylesheet with the API provided by UI and
UIInternals classes

Fixes #22631
@sonarqubecloud
Copy link

@github-actions
Copy link

Test Results

1 291 files  ± 0  1 291 suites  ±0   1h 14m 37s ⏱️ +12s
9 026 tests +16  8 958 ✅ +16  68 💤 +1  0 ❌ ±0 
9 487 runs  +24  9 408 ✅ +24  79 💤 +1  0 ❌ ±0 

Results for commit c4c9af7. ± Comparison against base commit aebe283.

This pull request removes 3 and adds 19 tests. Note that renamed tests count towards both.
com.vaadin.flow.component.dependency.StyleSheetHotswapperTest ‑ cssResourceChange_knownPublicPaths_triggersLiveReloadUpdateWithRelativePath
com.vaadin.flow.component.dependency.StyleSheetHotswapperTest ‑ resourceChanged_cssNotIKnownPublicPath_ignore
com.vaadin.flow.component.dependency.StyleSheetHotswapperTest ‑ resourceChanged_notCss_ignore
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ cssResourceChange_knownPublicPaths_triggersLiveReloadUpdateWithRelativePath
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassChange_appShellInitialStateUpdated
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_appShellAddAnnotation_addsStylesheet
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_appShellModifyAnnotation_updatesStylesheet
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_appShellMultipleAnnotations_handlesMultiple
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_appShellNotRegistered_doesNothing
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_appShellRemoveAnnotation_removesStylesheet
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_closingUI_skipped
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_componentInUse_addsStylesheet
com.vaadin.flow.component.internal.StyleSheetHotswapperTest ‑ onClassesChange_componentModifyAnnotation_updatesStylesheet
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hot reload the changes in StyleSheet annotation

2 participants