-
Notifications
You must be signed in to change notification settings - Fork 66
feat: form binder object models support #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
platosha
wants to merge
46
commits into
main
Choose a base branch
from
feat/model-object-binder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 45 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
bd8fe14
feat(lit-form): preliminary object models support
platosha 19e9069
Merge branch 'main' into feat/model-object-binder
platosha cbe7a03
feat(models): constraints support
platosha 3e9b929
refactor(models): simplify constraint definitions
platosha aef40b0
fix(models): constraint test fixes
platosha 5ff5c36
feat(form): support object model constraints
platosha 82a1db2
fix(models): allow any key
platosha 11cb276
fix(models): TypeScript usage issues of optional, array and constrain…
platosha 00c466c
refactor(models): move constraints to separate directory
platosha 969d8e3
refactor(models): move constraints back to src directory, dirs are to…
platosha 2bf1f19
feat(models): missing features and fixes for binder
platosha da244d6
text(lit-form): use object models in tests
platosha 6fadcde
feat(models): make optional key have undefined default value
platosha 4565100
fix(lit-form): make basic value init work with object model
platosha f7f3fb9
fix(lit-form): basic array and object operations with object models
platosha a101edd
test(lit-form): forgotten constraint in test fixture
platosha e919ca0
fix(lit-form): correct binder node name
platosha 28d9eb4
test(lit-form): correct model name
platosha 2935b33
fix(models): improve constrant definitions for binder
platosha 6c5f757
fix(lit-form): support object models in field directive
platosha 88e34d4
fix(lit-form): field support for string object model
platosha 6b54ca7
fix(lit-form): combo box field support with array object models
platosha e6401f3
feat(models): enable optional self-referencing arrays
platosha cef1fdc
feat(models): optional array models
platosha 29a6e58
feat(models): nested self-referencing models
platosha 9bc6f8c
fix(models): keep original default value in optional models
platosha d3e519a
fix(models): make default value simple objects
platosha 88e803c
test(lit-form): correct fixture expectations
platosha 663c4a8
perf(models): cleanup & replace aliases with mapped types to avoid tr…
platosha 1d71b2b
fix(models): make number model carry NaN (empty value) by default
platosha 4fddfab
feat(react-form): support object models
platosha ebe0b45
feat(lit-form): expose stringConverter utility for react-form
platosha e18ea66
fix!(models): simplify object models more
platosha b6244f7
fix(models): deep self-referencing models
platosha ccf055d
fix(models): test fixes
platosha 66f2fb7
test(react-form): handle unhandled rejection in tests
platosha 21f3ee3
test(react-form): bring old tests back for now
platosha acf078f
Merge branch 'main' into feat/model-object-binder
platosha bcdcf85
fix(models): circular dependency
platosha e18ab24
chore: update package-lock.json
platosha 4ca417f
fix(models): simplify self references implementation
platosha 89732d2
fix(models): make output prettier for simple types
platosha 77531df
Merge branch 'main' into feat/model-object-binder
platosha ba89908
chore: update package-lock.json
platosha 54dadb4
fix: TypeScript errors
platosha d500bf6
Merge branch 'main' into feat/model-object-binder
Lodin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, this is wrong? 🤔