-
Notifications
You must be signed in to change notification settings - Fork 82
feat!: move vaadin-dev to vaadin-spring-boot-starter #8240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vaadin-dev is moved away from vaadin-core to vaadin-spring-boot-starter. PartOf: vaadin/flow#22715
| </dependency> | ||
| <dependency> | ||
| <groupId>com.vaadin</groupId> | ||
| <artifactId>vaadin-dev</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it also be changed to <optional>true</optional>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it optional here would have same effect as removing it. Which is against the ticket's spec "for Spring Boot projects this won't be a breaking change."
I know it would be beneficial for example for Gradle starters where we wouldn't need to exclude vaadin-dev explicitly then. But
do you have some specific use case in mind where it could be better to either mark it optional here or just remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to say without really testing it.. gonna do that later in the release circle. My current understanding would be that using optional=true would be no breaking change when starting via IDE, otherwise spring devtools would also be missing. But it's just my gut feeling.. nothing tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this earlier with Spring Boot RC1 (and M3), optional transitive dependency was not included and therefore both vaadin-dev and spring-boot-devtools are now added explicitly as optional dependency in vaadin spring starter apps.
More testing is appreciated so thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this now again with a custom platform snapshot and it's still same. Problem is that optional transitive dependency is not included at all, which means that running via IDE will end up to "DevModeHandlerManager not found" or "missing dev bundle" depending on "frontendHotdeploy" mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also try the following? That's how spring initializr is creating it's pom with 4.0.0-rc.2
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-devtools</artifactId>
<scope>runtime</scope>
<optional>true</optional>
</dependency>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet. I'll give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtime scope didn't change anything in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn.. that's sad.. thanks for checking!
vaadin-dev is moved away from vaadin-core to vaadin-spring-boot-starter.
PartOf: vaadin/flow#22715