Skip to content

Conversation

@tltv
Copy link
Member

@tltv tltv commented Nov 14, 2025

vaadin-dev is moved away from vaadin-core to vaadin-spring-boot-starter.

PartOf: vaadin/flow#22715

vaadin-dev is moved away from vaadin-core to vaadin-spring-boot-starter.

PartOf: vaadin/flow#22715
</dependency>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it also be changed to <optional>true</optional>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it optional here would have same effect as removing it. Which is against the ticket's spec "for Spring Boot projects this won't be a breaking change."
I know it would be beneficial for example for Gradle starters where we wouldn't need to exclude vaadin-dev explicitly then. But
do you have some specific use case in mind where it could be better to either mark it optional here or just remove?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say without really testing it.. gonna do that later in the release circle. My current understanding would be that using optional=true would be no breaking change when starting via IDE, otherwise spring devtools would also be missing. But it's just my gut feeling.. nothing tested

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this earlier with Spring Boot RC1 (and M3), optional transitive dependency was not included and therefore both vaadin-dev and spring-boot-devtools are now added explicitly as optional dependency in vaadin spring starter apps.
More testing is appreciated so thanks in advance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this now again with a custom platform snapshot and it's still same. Problem is that optional transitive dependency is not included at all, which means that running via IDE will end up to "DevModeHandlerManager not found" or "missing dev bundle" depending on "frontendHotdeploy" mode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also try the following? That's how spring initializr is creating it's pom with 4.0.0-rc.2

    <dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-devtools</artifactId>
      <scope>runtime</scope>
      <optional>true</optional>
    </dependency>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet. I'll give it a try.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime scope didn't change anything in this context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn.. that's sad.. thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants