chore: build production package by default #1394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up Maven build configuration by removing need for production profile. Updates Maven build configuration to run build-frontend goal by default on package phase. With help of spring-boot-maven-plugin feature, includeOptional=false, vaadin-dev dependency is not included in production package. Part of vaadin/flow#22439
|
Also would need README update to reflect this approach. |
knoobie
reviewed
Oct 10, 2025
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| <configuration> | ||
| <!-- Set false to exclude optional dependencies like vaadin-dev. --> | ||
| <includeOptional>false</includeOptional> |
There was a problem hiding this comment.
General question: is the other PR of spring that automatically excludes development-tool(s) not better suited if applicable? This would reduce the need for users to customize their spring plugin if Vaadin Dev is automatically removed from the created artefact
There was a problem hiding this comment.
If that works as expected, we could also remove need for adding vaadin-dev explicitly as a optional dependency. It's worth to explore that more, hopefully it can be used without braking change (beta release is coming soon), but this includeOptional alone achieves the goal to remove need of production profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up Maven build configuration by removing need for production profile. Updates Maven build configuration to run
build-frontendgoal by default on package phase. With help ofspring-boot-maven-pluginfeature,includeOptional=false,vaadin-devdependency is not included in production package.Part of vaadin/flow#22439
WIP NOTICE: Requires Spring Boot 4.0.0-SNAPSHOT and running requires Flow compatibility.